Add DlTdoaRangingMeasurement decoder#97
Merged
SilverBzH merged 1 commit intogoogle:mainfrom Jan 31, 2025
Merged
Conversation
PetervdPerk-NXP
force-pushed
the
pr-dltdoa
branch
2 times, most recently
from
1ebb76b to
9132607
Compare
Contributor
Author
|
@hchataing would be able or know someone that could take a look at this PR? |
Contributor
|
Hi Peter, Henri is OOO until Jan 26th. Could you please amend to your commit message what part of the specification this is referring to ? I'll have a look myself. Thanks for the PR ! |
PetervdPerk-NXP
force-pushed
the
pr-dltdoa
branch
from
9132607 to
2cbac57
Compare
Contributor
Author
|
Hi @SilverBzH Thank your for your response, it's mostly based on this |
SilverBzH
suggested changes
Jan 22, 2025
Based from https://android.googlesource.com/platform/external/uwb/+/refs/heads/main/src/rust/uwb_uci_packets/src/lib.rs#102 DlTdoaRangingMeasurement from UCI DL-TDoA Ranging Measurement Result
PetervdPerk-NXP
force-pushed
the
pr-dltdoa
branch
from
2cbac57 to
a8638d3
Compare
SilverBzH
suggested changes
Jan 24, 2025
SilverBzH
approved these changes
Jan 27, 2025
Contributor
Author
|
@hchataing any open things from your end? |
Collaborator
No further comments to make on my side 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DlTdoaRanging definitions so measurement can be decoded.
Update pdl-compiler to 0.3.2 allowing duplicate if statements
Updates py/pica/pica/packets/uci.py as well